Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable horeka CI jobs #1685

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Disable horeka CI jobs #1685

wants to merge 2 commits into from

Conversation

MarcelKoch
Copy link
Member

@MarcelKoch MarcelKoch commented Oct 2, 2024

This PR disables CI jobs on horeka. In time for the release I would like to have our CI pass all stages.

Edit:
This also deletes the windows github jobs, although it doesn't fit the original PR topic ideally.

@MarcelKoch MarcelKoch added this to the Ginkgo 1.9.0 milestone Oct 2, 2024
@MarcelKoch MarcelKoch requested a review from a team October 2, 2024 13:36
@MarcelKoch MarcelKoch self-assigned this Oct 2, 2024
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Oct 2, 2024
@MarcelKoch MarcelKoch added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Oct 2, 2024
@upsj
Copy link
Member

upsj commented Oct 2, 2024

This should probably be rebased. Otherwise LGTM

@MarcelKoch
Copy link
Member Author

@upsj thanks for catching that. Maybe there is an option to make rebasing the default when updating a branch?

@upsj
Copy link
Member

upsj commented Oct 2, 2024

Not AFAIK, but I recently talked to somebody from GitHub, I'll bring it up with him.

Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the jobs instead of disabling them? Any future configuration I had in mind would not involve the split test/build configuration, so the jobs would no longer be necessary.

Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants