newwindow and clipboard and eventloop::new #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for ruby side see in tests, or in clipboard i commented ruby equivalents for tht file |
|
tests do fail on ci due to cant open display i am not sure how to do them on ci yet(any suggestions for this ?) |
gintama91
commented
Jun 30, 2023
|
|
||
| unsafe impl<T> Send for SafeWrapper<T> {} | ||
|
|
||
| impl EventLoop { |
There was a problem hiding this comment.
i am not implementing event_loop further(as of now) as per discussion in discord
|
Yeah, headless testing on GTK+ is going to be interesting. People do this kind of thing -- Docker supports a headless mode where it keeps a virtual display, I can see answers about e.g. Sway, a Wayland window manager that will do it. I'm not sure what we want to use. I haven't done Linux headless GUI testing in a long time, and the tools have changed a lot. |
gintama91
commented
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.