-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple thresholds #21
Conversation
osteenbergen
commented
Aug 14, 2019
- options.thresholds = [100, 75, 50, 25]; Multiple thresholds #3
- Added some maskPadding to prevent some clipping on the bottom and top of the graph Chartist Threshold - Line graph getting cropped on highest value #8
- Added prefix to support multiple graphs on a single page Showing multiple charts makes the area coloring go wrong #11
- options.thresholds = [100, 75, 50, 25]; - Added some maskPadding to prevent clipping on the bottom and top of the graph - Added prefix to support multiple graphs on a single page
Hey thanks! I appreciate the feature! Will look into the PR soon. |
Precisely what I need, would love for this to be included. |
@gionkunz Any chance of this getting a code review? |
Used this plugin mod for one of my project - it saved a lot of time for me! @osteenbergen, thank you very much! One note. When several charts initialised with different thresholds, you have to manually set uniqe mask names for each chart! |
Do you have some example code for this? I'm struggling to set up multiple thresholds and style each differently, I only have ct-threshold-below and ct-threshold-above to work with? |
Depending on the
.ct-point {
stroke-width: 5px;
}
.ct-point.ct-threshold-above {
stroke: green;
}
.ct-point.ct-threshold-area-0 {
stroke: yellow;
}
.ct-point.ct-threshold-area-1 {
stroke: orange;
}
.ct-point.ct-threshold-below {
stroke: red;
} |
@gionkunz Its been a year, any luck on merging this PR? Do you require improvements? |
great stuff! Seems quite a lot of the chartist repo's are not being maintained |
Closing this PR as this project is not maintained.... |