Skip to content

Conversation

inkeliz
Copy link
Contributor

@inkeliz inkeliz commented Jul 7, 2023

No description provided.

@inkeliz inkeliz marked this pull request as ready for review July 8, 2023 12:23
@inkeliz
Copy link
Contributor Author

inkeliz commented Jul 8, 2023

That depends on gioui/gio#117

@inkeliz inkeliz changed the title gogio: add deeplink support [WIP] gogio: add deeplink support Jul 8, 2023
@inkeliz inkeliz requested a review from eliasnaur June 3, 2024 18:11
@inkeliz inkeliz requested a review from eliasnaur June 10, 2024 17:58
}

func buildInfoPlist(bi *buildInfo) string {
func buildInfoPlist(bi *buildInfo) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this function can return a non-nil error anymore.

return err
}

func (b *macBuilder) setInfo(buildInfo *buildInfo, name string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@eliasnaur eliasnaur force-pushed the main branch 4 times, most recently from 207e6f8 to 01ffdf7 Compare March 21, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants