use assertContains in pytest-style tests

lacommunaute/forum/tests/test_CategoryForumListView.py

@@ -1,5 +1,6 @@
 import pytest  # noqa
 from django.urls import reverse
+from pytest_django.asserts import assertContains
 
 from lacommunaute.forum.enums import Kind as ForumKind
 from lacommunaute.forum.factories import ForumFactory
@@ -9,9 +10,8 @@
 def test_context(client, db):
     url = reverse("forum_extension:documentation")
     response = client.get(url)
-    assert response.status_code == 200
     assert "forum/category_forum_list.html" == response.templates[0].name
-    assert reverse("pages:statistiques") in str(response.content)
+    assertContains(response, reverse("pages:statistiques"), status_code=200)
 
 
 def test_queryset(client, db):

lacommunaute/forum_upvote/tests/test_forumupvoteview.py

@@ -1,6 +1,7 @@
 import pytest  # noqa
 from django.urls import reverse
 from machina.core.db.models import get_model
+from pytest_django.asserts import assertContains
 
 from lacommunaute.forum.factories import ForumFactory
 from lacommunaute.forum_upvote.models import UpVote
@@ -32,14 +33,16 @@ def test_upvote_downvote_with_permission(client, db):
 
     # upvote
     response = client.post(url, data=form_data)
-    assert response.status_code == 200
-    assert '<i class="ri-bookmark-fill" aria-hidden="true"></i><span class="ml-1">1</span>' in str(response.content)
+    assertContains(
+        response, '<i class="ri-bookmark-fill" aria-hidden="true"></i><span class="ml-1">1</span>', status_code=200
+    )
     assert UpVote.objects.get()
 
     # downvote
     response = client.post(url, data=form_data)
-    assert response.status_code == 200
-    assert '<i class="ri-bookmark-line" aria-hidden="true"></i><span class="ml-1">0</span>' in str(response.content)
+    assertContains(
+        response, '<i class="ri-bookmark-line" aria-hidden="true"></i><span class="ml-1">0</span>', status_code=200
+    )
     assert not UpVote.objects.all()
 
 

lacommunaute/forum_upvote/tests/test_postupvoteview.py

@@ -2,6 +2,7 @@
 from django.contrib.contenttypes.models import ContentType
 from django.urls import reverse
 from machina.core.db.models import get_model
+from pytest_django.asserts import assertContains
 
 from lacommunaute.forum.factories import ForumFactory
 from lacommunaute.forum_conversation.factories import TopicFactory
@@ -34,8 +35,9 @@ def test_upvote_with_permission(client, db):
 
     # upvote
     response = client.post(url, data=form_data)
-    assert response.status_code == 200
-    assert '<i class="ri-bookmark-fill" aria-hidden="true"></i><span class="ml-1">1</span>' in str(response.content)
+    assertContains(
+        response, '<i class="ri-bookmark-fill" aria-hidden="true"></i><span class="ml-1">1</span>', status_code=200
+    )
     assert UpVote.objects.get(
         voter_id=user.id,
         object_id=topic.first_post.id,
@@ -44,8 +46,9 @@ def test_upvote_with_permission(client, db):
 
     # downvote
     response = client.post(url, data=form_data)
-    assert response.status_code == 200
-    assert '<i class="ri-bookmark-line" aria-hidden="true"></i><span class="ml-1">0</span>' in str(response.content)
+    assertContains(
+        response, '<i class="ri-bookmark-line" aria-hidden="true"></i><span class="ml-1">0</span>', status_code=200
+    )
     assert not UpVote.objects.all()