[UPVOTE] convertir la clé étrangère Post en clé étrangère générique #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
force-pushed
the
351-forum-upvote
branch
from
82b32c3
to
02e18b2
Compare
vincentporte
changed the title
vincentporte
force-pushed
the
351-forum-upvote
branch
2 times, most recently
from
74bad72
to
031807a
Compare
vincentporte
force-pushed
the
351-forum-upvote
branch
from
031807a
to
4193123
Compare
francoisfreitag
approved these changes
Jul 24, 2023
| for upvote in UpVote.objects.all(): | ||
| upvote.content_object = upvote.post | ||
| upvote.object_id = upvote.post_id | ||
| upvote.content_type = ContentType.objects.get_for_model(upvote.post) |
There was a problem hiding this comment.
On pourrait sortir cette requête de la boucle pour accélérer la migration.
lacommunaute/forum_upvote/models.py
Outdated
| verbose_name="Post", | ||
| ) | ||
| content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE) | ||
| object_id = models.PositiveIntegerField() |
There was a problem hiding this comment.
https://docs.djangoproject.com/en/4.2/ref/models/fields/#positivebigintegerfield
Par défaut, le projet semble utiliser les BigAutoFields, donc un entier entre 1 et 2^64-1.
https://github.com/betagouv/itou-communaute-django/blob/master/config/settings/base.py#L215
|
merci @francoisfreitag ! |
vincentporte
force-pushed
the
351-forum-upvote
branch
2 times, most recently
from
0275e3d
to
838986f
Compare
…dle data migration
vincentporte
force-pushed
the
351-forum-upvote
branch
from
838986f
to
96bb1b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Remplacer la clé étrangère
Postdans le modèleUpVotepar uneGenericForeignKeypour préparer l'upvote d'autres objets de la communauté (ie lesForum)Type de changement
🚧 technique, fait suite à la PR #356
Points d'attention
🦺 dans le modele
UpVote, transformer laForeignKeyversPostenGenericForeignKey🦺 migrer les données aller-retour
🦺 adapter les appels à
UpVoteFactoryet lesUpVote.objects.filter()existants🦺 ajout d'une
GenericRelationdu modelePostvers le modèleUpVote