[RECHERCHE] barre de recherche dans le header #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modification UI Et en passant, maniaquerie perso sur le bouton de Favoris -> Apres (oui faut vouloir le voir) |
hellodeloo
reviewed
Sep 5, 2023
| </button> | ||
| <form class="mb-3 mb-xl-0 mr-xl-2" action="{% url 'forum_search_extension:search' %}"> | ||
| <div class="input-group input-group-rounded-pill"> | ||
| <input class="form-control" type="search" placeholder="{% trans "Search" %} {% trans "Keywords or phrase" %}" aria-label="{% trans "Keywords or phrase" %}" name="q"> |
There was a problem hiding this comment.
@vincentporte Le texte du placeholder reste a adapter. Genre "Rechercher par mots clés ou phrase" ou simplement "Rechercher" ? Qu'est ce t'en dis ?
There was a problem hiding this comment.
"Rechercher" sera parfait !
vincentporte
commented
Sep 6, 2023
| data-matomo-category="engagement" | ||
| data-matomo-action="upvote" | ||
| data-matomo-option="post" | ||
| > | ||
| <i class="{% if obj.has_upvoted %}ri-bookmark-fill{% else %}ri-bookmark-line{% endif %}" aria-hidden="true"></i><span class="ml-1">{{counter}}</span> | ||
| <i class="{% if obj.has_upvoted %}ri-bookmark-fill{% else %}ri-bookmark-line{% endif %} mr-1" aria-hidden="true"></i><span>{{counter}}</span> |
There was a problem hiding this comment.
J'en profite pour remplacer tous les " aria-hidden="true"></i><span class="ml-1"> par mr-1" aria-hidden="true"></i><span>
La modif concerne aussi les likes (ri-heart-3-xxx)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 cf titre
Type de changement
🎨 UX