refactor(documentation): partie 5, ajout de la vue de consultation de détail du modèle document de l'app documentation
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
added
python
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lacommunaute/utils/html.py
Outdated
|
|
||
| iframe_regex = r"((<div>)?<iframe[^>]*>.*?<\/iframe>(<\/div>)?)" | ||
|
|
||
| for match, starts_with, ends_with in re.findall(iframe_regex, text, re.DOTALL): |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
vincentporte
force-pushed
the
765-part4
branch
from
6342bcd
to
953df84
Compare
vincentporte
force-pushed
the
765-part5
branch
from
8d7ceac
to
b739176
Compare
vincentporte
force-pushed
the
765-part4
branch
2 times, most recently
from
8a223e8
to
7e484e8
Compare
vincentporte
force-pushed
the
765-part5
branch
from
b739176
to
793ad84
Compare
vincentporte
force-pushed
the
765-part4
branch
from
7e484e8
to
b4b28bf
Compare
vincentporte
force-pushed
the
765-part5
branch
from
793ad84
to
c5a17d2
Compare
vincentporte
force-pushed
the
765-part4
branch
from
b4b28bf
to
951af0a
Compare
vincentporte
force-pushed
the
765-part5
branch
from
c5a17d2
to
f15f295
Compare
vincentporte
force-pushed
the
765-part4
branch
from
951af0a
to
e241b22
Compare
vincentporte
force-pushed
the
765-part5
branch
from
dea4d1b
to
6ecbc48
Compare
vincentporte
changed the title
document de l'app documentationdocument de l'app documentation
vincentporte
requested review from
calummackervoy,
hellodeloo and
francoisfreitag
This was referenced Sep 30, 2024
| [ | ||
| (lambda document: None, "document_detail_view"), | ||
| ( | ||
| lambda document: setattr(document, "partner", PartnerFactory(for_snapshot=True)) or document.save(), |
There was a problem hiding this comment.
Tu peux utiliser un def pour avoir plusieurs statements, au lieu de jouer avec le fait que setattr retourne None 🙈
Ça permettrait aussi de faire l’assignement directement, sans passer par setattr. 🤷
| <div class="col-12 col-lg-3 vertical-line"> | ||
| <p class="h3 text-decoration-none d-inline-block">Les autres fiches du thème {{ document.category.name }}</p> | ||
| <ul class="nav nav-tabs flex-column"> | ||
| {% for document_in_category in document.category.documents.all %} |
There was a problem hiding this comment.
J’imagine qu’on souhaitera exclure document.pk de la liste ?
vincentporte
force-pushed
the
765-part4
branch
from
e241b22
to
465607d
Compare
vincentporte
force-pushed
the
765-part5
branch
from
6ecbc48
to
5ea7e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #765
Description
🎸 Ajout de la vue de detail de
Documentet de ses gabaritsType de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🎨 changement d'UI
Points d'attention
🦺 suite PR #786
🦺 Mise à jour de
breadcrumb🦺 Ajout d'un test manquant concernant le remplacement des images dans
parse_response_to_soup🦺 Enrichissement de
parse_response_to_souppour rendre les snapshot agnostiques vis-à-vis des dates de mises à jourCaptures d'écran (optionnel)
DocumentDetailView