chore: login in debug/dev mode #829
Draft
+228
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
requested review from
rsebille,
leo-naeka,
xavfernandez,
celine-m-s and
tonial
tonial
reviewed
Nov 19, 2024
| @@ -38,6 +40,10 @@ def send_magic_link(user, next_url): | |||
| template_id=settings.SIB_MAGIC_LINK_TEMPLATE, | |||
| ) | |||
|
|
|||
| if settings.DEBUG is True: | |||
There was a problem hiding this comment.
tu as besoin d'ajouter cette spécificité pour le debug ? est-ce que le mode de production ne devrait pas suffir ?
Comment on lines
+72
to
+74
| <div id="debug-mode-banner"> | ||
| {% if DEBUG %}<div class="bg-danger text-white mt-3">DEBUG MODE</div>{% endif %} | ||
| </div> |
There was a problem hiding this comment.
On pourrait wrapper le div entière dans le {% if %} pour ne pas avoir la div#debug-mode-banner en prod.
| @@ -38,6 +40,10 @@ def send_magic_link(user, next_url): | |||
| template_id=settings.SIB_MAGIC_LINK_TEMPLATE, | |||
| ) | |||
|
|
|||
| if settings.DEBUG is True: | |||
| message = mark_safe(f'<a href="{login_link}">Login link</a> sent to {user.email}') | |||
There was a problem hiding this comment.
Ce n’est pas safe. format_html avec deux paramètres ?
Comment on lines
+22
to
+31
| @override_settings( | ||
| DEBUG=True, | ||
| INSTALLED_APPS=[app for app in settings.INSTALLED_APPS if app != "debug_toolbar"], | ||
| MIDDLEWARE=[ | ||
| middleware | ||
| for middleware in settings.MIDDLEWARE | ||
| if middleware != "debug_toolbar.middleware.DebugToolbarMiddleware" | ||
| ], | ||
| DEBUG_TOOLBAR_CONFIG={}, | ||
| ) |
There was a problem hiding this comment.
Tu ne voulais pas réutiliser la fixture override_debug_toolbar_settings_fixture ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 lorsque le mode DEBUG est actif:
django.contrib.auth.urlsType de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🚧 technique
Points d'attention
🦺 passage de la valeur de la variable
DEBUGdans lecontext_processorCaptures d'écran (optionnel)
Banniere Debug Mode
Lien cliquable d'authentification en mode debug