Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Emails): Bouger la méthode d'ajout à une liste de contact dans les utils #1102

Merged
merged 2 commits into from
Mar 27, 2024
Merged

refactor(Emails): Bouger la méthode d'ajout à une liste de contact dans les utils #1102

merged 2 commits into from
Mar 27, 2024

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Feb 23, 2024 •
edited
Loading

Quoi ?

  • bougé get_mailjet_cl_on_signup vers api_mailjet.py
  • bougé add_to_contact_list vers utils/emails.py
  • bougé EMAIL_SUBJECT_PREFIX vers utils/constants.py
  • enlevé certains typing hints à cause d'erreur de "circular import"

@raphodn raphodn force-pushed the raphodn/brevo-mailjet-contact-refactor branch 3 times, most recently from 7266e82 to f1108dc Compare March 13, 2024 10:37
@raphodn raphodn force-pushed the raphodn/brevo-mailjet-contact-refactor branch from f1108dc to c38f242 Compare March 21, 2024 09:37
@raphodn raphodn marked this pull request as ready for review March 21, 2024 11:46
madjid-asa
madjid-asa approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphodn raphodn changed the title refactor(emails): Bouger la méthode d'ajout à une liste de contact dans les utils refactor(Emails): Bouger la méthode d'ajout à une liste de contact dans les utils Mar 27, 2024
@raphodn raphodn merged commit 50cc60e into master Mar 27, 2024
6 checks passed
@raphodn raphodn deleted the raphodn/brevo-mailjet-contact-refactor branch March 27, 2024 08:13
raphodn added a commit that referenced this pull request Mar 28, 2024
@raphodn
fix: erreur sur une variable non définie. ref #1102
ecadcd0
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madjid-asa madjid-asa madjid-asa approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @madjid-asa