feat: Ajout d'un attribut pour filtrer l'envoi des besoins d'achat #1446
+177
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…voi aux partenaires
…al_partners_only est True
…alidated_sent_batch'
madjid-asa
requested changes
Oct 1, 2024
| if obj.amount_int > settings.BREVO_TENDERS_MIN_AMOUNT_TO_SEND: | ||
| api_brevo.create_deal(tender=obj, owner_email=request.user.email) | ||
| # we link deal(tender) with author contact | ||
| api_brevo.link_deal_with_contact_list(tender=obj) | ||
| self.message_user(request, "Ce dépôt de besoin a été synchronisé avec Brevo") | ||
| self.message_user(request, "Ce dépôt de besoin a été validé. Il sera envoyé en temps voulu :)") | ||
| obj.save() |
There was a problem hiding this comment.
Pas besoin du .save() le set_validated le fait déjà, mais du coup tu peux remonter obj.send_to_commercial_partners_only = True pour le mettre avant le set_validated
| @@ -632,6 +633,9 @@ class Tender(models.Model): | |||
| ) # could become foreign key | |||
| # Admin specific for tenders | |||
| is_reserved_tender = models.BooleanField("Appel d'offre reservé", null=True) | |||
| send_to_commercial_partners_only = models.BooleanField( | |||
| "Envoyer uniquement aux partenaires externes", default=False | |||
There was a problem hiding this comment.
Suggested change
| "Envoyer uniquement aux partenaires externes", default=False | |
| "Envoyer uniquement aux partenaires commerciaux", default=False |
Préciser commerciaux pour ne pas confondre avec les partenaires externes (types facilitateurs ou autre)
Comment on lines
+25
to
+26
| const recipient = button.getAttribute('data-recipient'); | ||
| const title = button.getAttribute('data-title'); |
There was a problem hiding this comment.
Suggested change
| const recipient = button.getAttribute('data-recipient'); | |
| const title = button.getAttribute('data-title'); | |
| const recipient = button.dataset.recipient; | |
| const title = button.dataset.title; |
Tu utilise généralement les getAttribute pour les attributs non-standards, mais pour les data-* tu peux utiliser dataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Permettre aux admins d’affecter certains dépôts de besoins à des partenaires.
Pourquoi ?
Des partenaires externes en ont fait la demande.
Comment ?
En ajout d'un bouton "Valider et envoyer aux partenaires" dans l'admin des tenders.
En ajoutant un attribut 'send_to_commercial_partners_only' dans le modèle Tender qui sera set à True en cliquant sur le bouton "Valider et envoyer aux partenaires".
En modifiant la méthode 'validated_sent_batch' de TenderQueryset pour filtrer les envois aux structures lorsque l'attribut est False
Captures d'écran (optionnel)
Ajout du bouton
Modale avec message personnalisé si structures/partenaires
Tests de l'attribut