Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SourceLink #21

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Banashek
Copy link

@Banashek Banashek commented Jul 3, 2022

Quick fix for the enhancement described in #16

Notes

I noticed Giraffe core is on 1.0.*

Judging by the release notes for 1.1.0, there's not much that would be different for this basic usage.

dustinmoris
dustinmoris previously approved these changes Jul 7, 2022
Copy link
Member

@dustinmoris dustinmoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dustinmoris
Copy link
Member

Really appreciate your contribution! Would you mind adding the version number fix to this PR as well to get the builds green again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants