Remove [<AllowNullLiteral>] attribute from Json.ISerializer and Xml.ISerializer #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
I'm approving to unblock you, but I have no deep technical knowledge here. Looks good from afar. When dotnet 10 drop, it might be a good idea to drop another major. If you have any other breaking changes...
You could add an "Unreleased" section to your release notes so that you don't forget this.
…ification and fix the code to deal with it
64J0
force-pushed
the
remove-allow-null-literal-attribute
branch
from
a300c75 to
0efa1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm:
[<AllowNullLiteral>]attribute from Json.ISerializer and Xml.ISerializer;Important
When releasing a new version, update the RELEASE_NOTES with a section for "breaking changes" mentioning this PR.
Related issues