Add new modifier to class methods that hide base class methods

[adamreeve]

• I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Resolves #1094

[badcel]

I'm not sure if the unit tests in this case are of the type I want to have: They are tightly coupled to the implementation. (Especially as I don't like the current Generator.Model approach.)

For generated code I would prefer to have tests that are independent from the generator implementation.

I don't know if this works out but my preferred solution would be to have some new GObject class which has a to_string method. The class would be here: https://github.com/gircore/gir.core/tree/main/src/Native/GirTestLib

There is a special GirTest project to interact with the library.

The warning which is emitted for the missing new / override operator must be converted to an error so the build would fail if it is missing. As the generator is applying the operator the build would not fail. The test would then call the method to verify the expected string is returned.

Additionally the instance can be casted to System.Object to call System.Object.ToString method and verify the original implementation is still accessible.

What do you think?

[adamreeve]

Thanks for the feedback, yes that seems like a better approach. I wasn't that happy with how the tests were implemented either but didn't think of changing the test project to treat the warning as an error.

[badcel]

I checked the code and except the new parameter to force the new modifier it looks fine to me. Let's see what your thoughts on my comment are.