Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue searching for annotation metadata #1723

Merged
merged 1 commit into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@

- Openslide now requires the binary wheel on appropriate platforms ([#1709](../../pull/1709), [#1710](../../pull/1710))

### Bug Fixes

- Fix an issue searching for annotation metadata on items that a user doesn't have permissions to view ([#1723](../../pull/1723))

## 1.30.2

### Features
Expand Down
7 changes: 6 additions & 1 deletion girder/girder_large_image/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,12 @@
if id in foundIds:
continue
foundIds.add(id)
entry = resultModelInst.load(id=id, user=user, level=level, exc=False)
try:
entry = resultModelInst.load(id=id, user=user, level=level, exc=False)
except Exception:

Check warning on line 433 in girder/girder_large_image/__init__.py

View check run for this annotation

Codecov / codecov/patch

girder/girder_large_image/__init__.py#L433

Added line #L433 was not covered by tests
# We might have permission to view an annotation but not
# the item
continue

Check warning on line 436 in girder/girder_large_image/__init__.py

View check run for this annotation

Codecov / codecov/patch

girder/girder_large_image/__init__.py#L436

Added line #L436 was not covered by tests
if entry is not None and offset:
offset -= 1
continue
Expand Down