fix github actions runs on forks #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains two separate fixes: 1) use lowercased github username/repository for the docker repository name. This is because image registries only accept lowercase in image repository names, but github stores the repository and username in a case-sensitive manner. This broke image uploads for me, as my username has uppercase chars. 2) change run conditions for some steps. It will no longer attempt to set up SSH web publishing if the SSH private key is not set. It will also run the image registry upload steps if registry usernames are missing, instead skipping individual uploads where the token for that registry is missing. Finally, it simplifies the sccache run conditions to use the `SCCACHE_GHA_ENABLED` env variable, rather than duplicating that logic. Signed-off-by: Jade Ellis <[email protected]>
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains two separate fixes:
use lowercased github username/repository for the docker repository name.
This is because image registries only accept lowercase in image repository names, but github stores the repository and username in a case-sensitive manner. This broke image uploads for me, as my username has uppercase chars.
change run conditions for some steps.
It will no longer attempt to set up SSH web publishing if the SSH private key is not set.
It will also run the image registry upload steps if registry usernames are missing, instead skipping individual uploads where the token for that registry is missing.
Finally, it simplifies the sccache run conditions to use the
SCCACHE_GHA_ENABLEDenv variable, rather than duplicating that logic.