Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue#107 #108

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Fix for Issue#107 #108

merged 6 commits into from
Jun 20, 2023

Conversation

nmalasevic
Copy link
Contributor

Fix for issue I reported here:
#107

@nmalasevic nmalasevic mentioned this pull request Jun 19, 2023
Closed
nilsnolde
nilsnolde reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks!

Can you please add an entry to the changelog? I forget that way too often.

nilsnolde
nilsnolde reviewed Jun 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nmalasevic
Copy link
Contributor Author

I moved it to the correct section. I haven't done that initially since it's still not in master branch, so messed it up :)

nilsnolde
nilsnolde reviewed Jun 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nilsnolde
nilsnolde approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, we squash by default

@nilsnolde nilsnolde merged commit 10c7bb3 into gis-ops:master Jun 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde nilsnolde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmalasevic @nilsnolde