feat: router for OpenTripPlanner

[khamaileon]

[nilsnolde]

Thanks @khamaileon , very good effort! You're the first one actually contributing a whole provider 💯

This seems to target OTP v1.x right? I had little exposure to their API, but I do see an isochrone implementation and AFAIK that was dropped in v2.x (though I heard that it'll be re-implemented due to popular demand or maybe it was already?). In that case we should probably name this provider OpenTripPlannerV1 (or OpenTripPlannerV2 respectively, v1 is still in wide use)?

I don't have much to review on the API side, just a few conceptual questions and nits. Since we didn't merge the "live request" support yet, I'd trust you there and handle bugs as they appear.

[khamaileon]

Thanks you 🙂. This is only a first draft. I've already identified few improvements.

It's v2. You're right, it's better to specify it. Isochrone is implemented. Sorry, I had force-pushed and maybe you've only seen the first draft.

[nilsnolde]

Sure, no worries, I thought it was done for you. I converted your PR into a draft PR so it's clearer. Just un-draft it once you're ready:) Thanks!

[khamaileon]

Ah I thought I'd drafted it. Hence the misunderstanding thank you! Okay, it's ready now :)

[nilsnolde]

Sorry for the delay on this, I’ll have a look until the end of the week.

[khamaileon]

No worries, ty @nilsnolde

[nilsnolde]

nit: we could allow shortcutting to otp_v2?

[khamaileon]

Done :)

[khamaileon]

Thanks for the review. I'll let you do the merge :)

[nilsnolde]

Interesting, Github changed smth, usually it'd require a re-approve. Maybe bcs only the commented file changed..

Anyways, thanks, this is great!