Do not check empty passwords

gisostallenberg · Dec 2, 2015 · 5be41f0 · 5be41f0
1 parent d45af9b
commit 5be41f0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/CorrectHorseBatteryStaple.php b/src/CorrectHorseBatteryStaple.php
@@ -2,10 +2,10 @@
 
 namespace GisoStallenberg\CorrectHorseBatteryStaple;
 
+use InvalidArgumentException;
 use Symfony\Component\Process\Exception\ProcessFailedException;
 use Symfony\Component\Process\Exception\RuntimeException;
 use Symfony\Component\Process\Process;
-use Symfony\Component\Process\ProcessBuilder;
 
 class CorrectHorseBatteryStaple {
     /**
@@ -78,6 +78,9 @@ private function verifyCommand() {
      * @throws ProcessFailedException
      */
     public function check($password) {
+        if (empty($password) ) {
+            throw new InvalidArgumentException('The password cannot be empty');
+        }
         $process = new Process($this->command);
         $process->setInput($password);
         $process->mustRun();

diff --git a/tests/CorrectHorseBatteryStapleTest.php b/tests/CorrectHorseBatteryStapleTest.php
@@ -20,6 +20,16 @@ public function testConstruct()
         new CorrectHorseBatteryStaple();
     }
 
+    /**
+     * Tests if checking an empty password fails
+     *
+     * @expectedException InvalidArgumentException
+     */
+    public function testInvalidStringConstruct()
+    {
+        (new CorrectHorseBatteryStaple() )->check('');
+    }
+
     /**
      * Tests if the getters return expected results.
      *