Adds search feature to commands when the URL includes "{q}" or "%s" #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured that URLs used when calling WebAppService.StartUrl(url, profile) have either http:// or https:// URL schemes, since Chrome requires a URL scheme to start.
Add the ability to use "{q}" or "%s" when adding new URLs, that will be replaced with terms for web search query when using that URL/command.
Example:
wap add https://duckduckgo.com/?q={q} ddg [default]
When using that command:
wap ddg banana split
Resulting URL used:
https://duckduckgo.com/?q=banana%20split
Another example:
wap add https://time.is/?q={q} time [default]
When using that command:
wap time paris france
Resulting URL used:
https://time.is/?q=paris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds search feature to commands when the URL includes "{q}" or "%s"
Replaces "{q}" or "%s" in a URL when using a command with whatever the user types after the command, handles spaces and replaces them with "%20" to URL encode them in a basic way.
Also ensures that when URLs are started they have either http:// or https:// URL schemes, since Chrome requires a URL scheme to start that URL.
Examples
When using that command:
Resulting URL used:
When using that command:
Resulting URL used:
When using that command:
Resulting URL used: