Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal and select component fixes #4253

Merged
merged 38 commits into from
Jul 8, 2024
Merged

Modal and select component fixes #4253

merged 38 commits into from
Jul 8, 2024

Conversation

PavelLaptev
Copy link
Contributor

@PavelLaptev PavelLaptev commented Jul 6, 2024 •
edited
Loading

Select Component and Context Menu Refactoring

  • Simplified context menu usage.
  • Removed components that duplicated the context menu, such as the Popup component.
  • Added appearing animations to Select and all context menus.
  • Components now mount only when triggered.
  • Mounted components to the body level to prevent any overflow issues.
  • Added searchable option to the Select component

Context menu

Screen.Recording.2024-07-06.at.22.54.12.mov

Select

Screen.Recording.2024-07-06.at.22.54.58.mov

@PavelLaptev @gitbutler-client
feat: fix clickoutside for multi modal case, fix select list options …
aa29d82 
…display.
@PavelLaptev @gitbutler-client
Move select to a separate folder
81bd7cc
@PavelLaptev @gitbutler-client
Serach field CSS tweak
5a1d528
@PavelLaptev @gitbutler-client
Replace the old Select with the new one
9697cd7
@PavelLaptev @gitbutler-client
Remove old Select component and switch SelectNew component name
2a1e1b5
@PavelLaptev @gitbutler-client
Added $effect type to eslint config
22cef05
@PavelLaptev @gitbutler-client
Added the searchable property to Select
43ad024
@PavelLaptev @gitbutler-client
disable text selection and added an animation
7178e17
@PavelLaptev @gitbutler-client
dropzone hover animation update
b1cf845
@PavelLaptev @gitbutler-client
Remove focus state outline
8cab988
@PavelLaptev @gitbutler-client
Move Listitem to ProjectPopup as a snippet
dcb6828
@PavelLaptev @gitbutler-client
rename useResize to resizeObserver
0dc9245
@PavelLaptev @gitbutler-client
Rename useAutoHeight to autoHeight
10d0f89
@PavelLaptev @gitbutler-client
remove unused component PopupMenuItem
098fe4b
@PavelLaptev @gitbutler-client
Update Unupply modal design
e02a32c
@PavelLaptev @gitbutler-client
Handle Select position on resize
6b6675b
@PavelLaptev @gitbutler-client
added an animation to the new context menu
710b501
@PavelLaptev @gitbutler-client
Right click context menu added
1a4380b
@PavelLaptev @gitbutler-client
revert right click context menu
04454ac
@PavelLaptev @gitbutler-client
Context menu: add item arg for the open method
d6a1456
@PavelLaptev @gitbutler-client
updated context menu for Filter, FileItem, branch kebab menu
26ee62a
@PavelLaptev @gitbutler-client
Updated Dropdown context menus
f6fa025
@PavelLaptev @gitbutler-client
Temporary remove copy PR link
d4c68dc
@PavelLaptev @gitbutler-client
Rename: BranchLanePopupMenu to BranchLaneContextMenu
3793340
@PavelLaptev @gitbutler-client
FileListItem uncomment commented code
01f49f0
@PavelLaptev @gitbutler-client
Hunk context menu updated
8eada5d
@PavelLaptev @gitbutler-client
Remove PopupMenu
5614053
@PavelLaptev @gitbutler-client
Replace the old ContextMenu file with the new one
af76b1a
@PavelLaptev @gitbutler-client
Added blocking overlay for dropdown context menus
ff9fd20
@PavelLaptev @gitbutler-client
animation timing update
15f8548
@github-actions github-actions bot added the app label Jul 6, 2024
@PavelLaptev PavelLaptev force-pushed the Modal-and-select-component-fixes branch 2 times, most recently from 6f843f2 to 998e9fc Compare July 8, 2024 08:56
@PavelLaptev PavelLaptev merged commit 2cdbc5e into master Jul 8, 2024
21 checks passed
@PavelLaptev PavelLaptev deleted the Modal-and-select-component-fixes branch July 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@PavelLaptev