Add manual check for app update #4699
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
github-actions
bot
added
rust
|
@ndom91 in what menu would be want to place this for linux users? |
|
@mtsgrd I think the "File" menu would be fine 👍 |
mtsgrd
force-pushed
the
Add-manual-update-app-check
branch
from
1a16ba3
to
398e7b2
Compare
|
@ndom91 cool, added it there! |
mtsgrd
force-pushed
the
Add-manual-update-app-check
branch
from
398e7b2
to
7879840
Compare
| const update = await Promise.race([ | ||
| checkUpdate(), // In DEV mode this never returns. | ||
| new Promise<UpdateResult>((resolve) => | ||
| setTimeout(() => resolve({ shouldUpdate: false }), 30000) |
There was a problem hiding this comment.
@PavelLaptev in dev mode you need to wait for this timeout until "up to date" should be displayed. In prod, the checkUpdate function above will also return shouldUpdate: false if no new binary is available.
PavelLaptev
force-pushed
the
Add-manual-update-app-check
branch
from
7879840
to
ec6053a
Compare
|
@mtsgrd I've updated the design. Could you please check to ensure everything works correctly? Here is the logic: 
|
|
Did you forget to check some things in? The font here is off, and I also see you're using modal width |
|
Interesting... There should be a few commits before the last one
|
mtsgrd
force-pushed
the
Add-manual-update-app-check
branch
from
ff9cdab
to
6977599
Compare
|
Thanks, the for some reason didn't pick up the changes until I touched a file in gitbutler-ui. |
|
I'm going to test this manually with a nightly build before merging! |
Sounds good, thanks :-) |
PavelLaptev
force-pushed
the
Add-manual-update-app-check
branch
from
6977599
to
592343b
Compare
…ipsis Just something I noticed about how other applications spell this.
- fixes things discovered in manual testing - avoid $effect loops
Adds a menu item for manually checking for updates. See issue #4683.