-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual check for app update #4699
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@ndom91 in what menu would be want to place this for linux users? |
@mtsgrd I think the "File" menu would be fine 👍 |
1a16ba3
to
398e7b2
Compare
@ndom91 cool, added it there! |
398e7b2
to
7879840
Compare
const update = await Promise.race([ | ||
checkUpdate(), // In DEV mode this never returns. | ||
new Promise<UpdateResult>((resolve) => | ||
setTimeout(() => resolve({ shouldUpdate: false }), 30000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PavelLaptev in dev mode you need to wait for this timeout until "up to date" should be displayed. In prod, the checkUpdate function above will also return shouldUpdate: false
if no new binary is available.
7879840
to
ec6053a
Compare
@mtsgrd I've updated the design. Could you please check to ensure everything works correctly? Here is the logic: ![]() |
ff9cdab
to
6977599
Compare
Thanks, the for some reason didn't pick up the changes until I touched a file in gitbutler-ui. |
I'm going to test this manually with a nightly build before merging! |
Sounds good, thanks :-) |
6977599
to
592343b
Compare
…ipsis Just something I noticed about how other applications spell this.
- fixes things discovered in manual testing - avoid $effect loops
Adds a menu item for manually checking for updates. See issue #4683.