-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: faster e2e runs #4705
fix: faster e2e runs #4705
Conversation
ndom91
commented
Aug 16, 2024
•
edited
Loading
edited
- Follow-up from: faster E2E runs #4692
- Use debug build for test to improve build time
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for picking this up! I gave up a little quickly there 😁. |
@mtsgrd what did you mean by your comment regarding |
Try adding another step in test-e2e.yaml that runs In the logs for the e2e run you see this error, albeit a bit hard to find: *edit: let's also add |
Hmm, even with an additional Previously (in master), building CLI generally takes ~30s and building Tauri app takes ~4m for a total of ~4m30s. In this PR, the two/three steps still take ~4m30s in total, just split up differently. I've passed |
@mtsgrd do you want to merge this as-is? Currently there is no real gain in overall duration. The current state is approximately like this: Before:
After:
I'm a bit out of my depth here with Rust build tooling, so if anyone else has a good idea I'm happy to try it, but otherwise I think my time is best spent elsewhere 👍 I was hoping this would be a simple(r) change haha |
Hmm, I'd say it's better to test the release build if we don't see a big gain in performance? It's testing something closer to the thing we distribute. |
Yeah agreed. I'll close this PR then 👍 |