Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faster e2e runs #4705

Closed
wants to merge 6 commits into from
Closed

fix: faster e2e runs #4705

wants to merge 6 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Aug 16, 2024

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 4:28pm

@ndom91 ndom91 changed the title fix: use debug build fix: faster e2e runs Aug 16, 2024
@Byron
Copy link
Collaborator

Byron commented Aug 16, 2024

Thanks for picking this up! I gave up a little quickly there 😁.

@ndom91
Copy link
Contributor Author

ndom91 commented Aug 16, 2024

@mtsgrd what did you mean by your comment regarding gitbutler-git exactly?

@mtsgrd
Copy link
Contributor

mtsgrd commented Aug 16, 2024

Try adding another step in test-e2e.yaml that runs cargo build -p gitbutler-git. I ran into this a few days ago, see this discord message: https://discord.com/channels/1060193121130000425/1204524097241878629/1271551056102424627

In the logs for the e2e run you see this error, albeit a bit hard to find:
image

*edit: let's also add RUST_BACKTRACE=1 to these e2e runs?

@ndom91
Copy link
Contributor Author

ndom91 commented Aug 16, 2024

Hmm, even with an additional cargo build -p gitbutler-git step, the Build CLI and Build Tauri (rest of application) steps don't seem to be reusing any of one anothers work.

Previously (in master), building CLI generally takes ~30s and building Tauri app takes ~4m for a total of ~4m30s. In this PR, the two/three steps still take ~4m30s in total, just split up differently.

I've passed --profile dev to each build cmd btw and also enabled the RUST_BACKTRACE=1 env var for the whole e2e workflow

@ndom91
Copy link
Contributor Author

ndom91 commented Aug 19, 2024

@mtsgrd do you want to merge this as-is? Currently there is no real gain in overall duration. The current state is approximately like this:

Before:

  • Build CLI: 30s
  • Build Tauri: 4m

After:

  • Build gitbutler-git: 30s
  • Build CLI: 2m
  • Build Tauri: 2m

I'm a bit out of my depth here with Rust build tooling, so if anyone else has a good idea I'm happy to try it, but otherwise I think my time is best spent elsewhere 👍 I was hoping this would be a simple(r) change haha

@mtsgrd
Copy link
Contributor

mtsgrd commented Aug 19, 2024

Hmm, I'd say it's better to test the release build if we don't see a big gain in performance? It's testing something closer to the thing we distribute.

@ndom91
Copy link
Contributor Author

ndom91 commented Aug 19, 2024

Hmm, I'd say it's better to test the release build if we don't see a big gain in performance? It's testing something closer to the thing we distribute.

Yeah agreed. I'll close this PR then 👍

@ndom91 ndom91 closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants