Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an additional page called DonorLists #1

Closed
wants to merge 20 commits into from

Conversation

realguy33
Copy link

I have added an additional file called DonorLists in the pages folder. This will allow projects to get a list of their donors. No other changes have been made.

Copy link
Collaborator

@ufkhan97 ufkhan97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for doing this. This is almost there. Can I request 1 change and two minor tweaks?

One change:
Instead of inputting a grant address or project ID, what do you think about providing a dropdown where they can click on a grant name? This list might get long if we allow it to be all grants in the program, you could also create a dropdown for selecting a round name.
I'm imagining:

  • Select Program
  • Select Round
  • Select Grant

What do you think?

Two minor tweaks:

  • Rename the columns before displaying: 'Grant Title', 'Voter', 'Token', 'Amount', 'AmountUSD', 'Round Name' This makes the presentation cleaner. (don't include block_timestamp bc it's an in-app estimate, but ff to include block number if you like)
  • if possible avoid @st.experimental_memo as it throws up a deprecation warning

@realguy33
Copy link
Author

Hi, just saw this reply(somehow missed it in my email). I'll try make those changes asap.

@ufkhan97
Copy link
Collaborator

ufkhan97 commented Dec 20, 2023

Hey @realguy33! just checking in here, how are things going ser?

@realguy33
Copy link
Author

Hi, Sorry for the delay! i had some previously unfinished freelance work whose deadline was approaching. I have started working on this. Shouldn't take long.

@henryguns
Copy link

beatful

@henryguns
Copy link

very very good

@Exelword
Copy link

🚀

@Minhtuan949
Copy link

Gm

@SMSDAO
Copy link

SMSDAO commented Sep 11, 2024

Thanks for changes bro

Copy link

@SMSDAO SMSDAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely right changes Thanks

@elypss
Copy link

elypss commented Sep 25, 2024

Gm

@ndquanghung
Copy link

Happy new year

@abdulkhalek884
Copy link

git

@abdulkhalek884
Copy link

Done

@ufkhan97 ufkhan97 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants