Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: storage check api limit qa #15

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ interface IUbiquityDollarToken is IERC20Ubiquity {
address indexed _incentiveContract
);

// modify file outside libraries

/**
* @notice Sets `incentive` contract for `account`
* @notice Incentive contracts are applied on Dollar transfers:
Expand Down
2 changes: 2 additions & 0 deletions packages/contracts/src/dollar/libraries/AddressUtils.sol
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import {UintUtils} from "./UintUtils.sol";
library AddressUtils {
using UintUtils for uint256;

// adding comment to see if it is picked up

/// @notice Thrown on insufficient balance
error AddressUtils__InsufficientBalance();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ library LibCollectableDust {
/// @notice Struct used as a storage for the current library
struct Tokens {
EnumerableSet.AddressSet protocolTokens;
uint256 findMe2;
}

/// @notice Storage slot used to store data for this library
Expand Down
1 change: 1 addition & 0 deletions packages/contracts/src/dollar/libraries/LibStaking.sol
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@
/// @notice Struct used as a storage for the current library
struct StakingData {
uint256 stakingDiscountMultiplier;
string findMe;

Check failure on line 63 in packages/contracts/src/dollar/libraries/LibStaking.sol

View workflow job for this annotation

GitHub Actions / check_storage_layout (src/dollar/libraries/LibStaking.sol:LibStaking)

Variable diff

variable "blockCountInAWeek" of type "uint256" was replaced by variable "findMe" of type "string" (storage slot 0x0000000000000000000000000000000000000000000000000000000000000001, byte #0)
uint256 blockCountInAWeek;

Check warning on line 64 in packages/contracts/src/dollar/libraries/LibStaking.sol

View workflow job for this annotation

GitHub Actions / check_storage_layout (src/dollar/libraries/LibStaking.sol:LibStaking)

Label diff

variable "accLpRewardPerShare" was renamed to "blockCountInAWeek". Is it intentional? (storage slot 0x0000000000000000000000000000000000000000000000000000000000000002, byte #0)
uint256 accLpRewardPerShare;

Check warning on line 65 in packages/contracts/src/dollar/libraries/LibStaking.sol

View workflow job for this annotation

GitHub Actions / check_storage_layout (src/dollar/libraries/LibStaking.sol:LibStaking)

Label diff

variable "lpRewards" was renamed to "accLpRewardPerShare". Is it intentional? (storage slot 0x0000000000000000000000000000000000000000000000000000000000000003, byte #0)
uint256 lpRewards;

Check warning on line 66 in packages/contracts/src/dollar/libraries/LibStaking.sol

View workflow job for this annotation

GitHub Actions / check_storage_layout (src/dollar/libraries/LibStaking.sol:LibStaking)

Label diff

variable "totalLpToMigrate" was renamed to "lpRewards". Is it intentional? (storage slot 0x0000000000000000000000000000000000000000000000000000000000000004, byte #0)
uint256 totalLpToMigrate;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ library LibTWAPOracle {
/// @notice Struct used as a storage for this library
struct TWAPOracleStorage {
address pool; // curve metapool address : Ubiquity Dollar <=> 3 Pool
uint256 findMe3;
// address token0; will always be address(this)
address token1; // curve 3pool LP token address
uint256 price0Average;
Expand Down
Loading