Add CI check for SPDX/copyright headers #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's automate the check on SPDX header and copyright notice for new files. This commit introduces a workflow to ensure that all source code files have these headers. It's simpler to rely on the check than to expect reviewers to think about it each time a new file is added to the repository. "Source code files" are currently defined as Rust files (.rs), shell scripts (.sh), and justfile. We could optimize this workflow to run only when source files are modified. But the check is to trivial that it's currently not worth the pain. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/ci-spdx-check
branch
from
18e6c79 to
e6409d7
Compare
|
Works as I expected: I'm removing the test commit. |
qmonnet
force-pushed
the
pr/qmonnet/ci-spdx-check
branch
from
e6409d7 to
f960351
Compare
mvachhar
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's automate the check on SPDX header and copyright notice for new files. This commit introduces a workflow to ensure that all source code files have these headers. It's simpler to rely on the check than to expect reviewers to think about it each time a new file is added to the repository.
"Source code files" are currently defined as Rust files (.rs), shell scripts (.sh), and justfile.
We could optimize this workflow to run only when source files are modified. But the check is to trivial that it's currently not worth the pain.