Add extensions for vtysh #1
Conversation
Add very simple support for vtysh extensions. The approach is similar to FRR's modules, but much simpler. FRR's modules cannot be used straight away since vtysh does not follow the same pattern as protocol daemons. E.g. it does not call frr_init(). Extensions are loaded with --extension|-X in the cmd line and can be displayed with "show vtysh extensions". Extensions are just like modules (some dynamically-loadable library) with entry point "vtysh_extension". The code expects that the extension return 0 on success and !=0 otherwise, but vtysh will start regardless. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
force-pushed
the
hh-vtysh-extensions
branch
from
8659802 to
a9e4551
Compare
I don't think there's a way to load our extensions without modifying FRR. We'll probably need to keep our own fork anyway. That being said, this patch is intentionally generic (and short) so that either option works. I thought of submitting the changes upstream, but I am not sure whether the community would be interested in something like this. I was going to defer that decision for a while.... |
Why not? There's probably someone else with a similar use case somewhere out there. Or maybe the maintainers have suggestions on how to make this work without patching FRR. I know it takes time to contribute upstream, but in return we get a smaller burden on our end. |
Add very simple support for vtysh extensions. The approach is similar to FRR's modules, but much simpler. FRR's modules cannot be used straight away since vtysh does not follow the same pattern as protocol daemons. E.g. it does not call frr_init(). Extensions are loaded with
--extension|-Xin the cmd line and can be displayed withshow vtysh extensions. Extensions are just like modules (some dynamically-loadable library) with entry pointvtysh_extension. The code expects that the extension return 0 on success and !=0 otherwise, but vtysh will start regardless.