GRPC Protoc messages for basic objects #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeymatov
force-pushed
the
pr/smatov/dataplane-grpc
branch
from
9011fc9 to
88ddd2e
Compare
qmonnet
reviewed
Feb 12, 2025
grpc/dataplane_grpc.proto
Outdated
|
|
||
| message PeeringPolicy { | ||
| string policy_name = 1; | ||
| repeated string peered_interfaces = 2; |
There was a problem hiding this comment.
I don't know gRPC and here I don't know what repeated means, it seems to be 1 or more. Is there a way to tell that we need just two peered_interfaces?
There was a problem hiding this comment.
repeated is a wide range, no exactly 2. We can make it exactly 2 by making 2 strings left_pif and right_pif
sergeymatov
force-pushed
the
pr/smatov/dataplane-grpc
branch
from
88ddd2e to
4f13f12
Compare
Frostman
requested changes
Feb 24, 2025
Signed-off-by: Sergey Matov <[email protected]>
sergeymatov
force-pushed
the
pr/smatov/dataplane-grpc
branch
from
4f13f12 to
646b344
Compare
Frostman
reviewed
Feb 25, 2025
| } | ||
|
|
||
| message Vpc { | ||
| string name = 1; |
There was a problem hiding this comment.
@sergeymatov do you think we need vpc-level vni too?
| uint32 vni = 3; | ||
| } | ||
|
|
||
| message PeeringInterface { |
There was a problem hiding this comment.
Let's not merge it until we agree on the GW API as it can affect PIFs/Policies significantly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.