Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herb #5991

Closed
wants to merge 8 commits into from
Closed

Herb #5991

wants to merge 8 commits into from

Conversation

yoidog
Copy link

@yoidog yoidog commented Jul 24, 2022

Description

Hello, this pull requests adds support for my own language Herb with the extension .herb, this is my first time and i'm excited, thanks. 😄

Checklist:

@yoidog yoidog requested a review from a team as a code owner July 24, 2022 01:33
@Nixinova
Copy link
Contributor

The new extension is used in hundreds of repositories on GitHub.com (they aren't Herb language.)

This checkbox is a requirement to being added to Linguist.
The language does not have usage on GitHub so this PR should be closed until it does.

@yoidog
Copy link
Author

yoidog commented Jul 24, 2022

The new extension is used in hundreds of repositories on GitHub.com (they aren't Herb language.)

This checkbox is a requirement to being added to Linguist. The language does not have usage on GitHub so this PR should be closed until it does.

I checked it!

@Nixinova
Copy link
Contributor

I checked it!

Just checking it doesn't make it true.
The language needs to be used in hundreds of repositories and there are only 35 .herb files, which is not enough for inclusion.

@lildude
Copy link
Member

lildude commented Jul 25, 2022

As pointed out by @Nixinova, usage is no where near meeting our documented requirements or even the temporarily relaxed requirements so I'm closing this PR. Please feel free to create a new one when popularity meets our requirements in future.

@lildude lildude closed this Jul 25, 2022
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants