Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .h.in to C #7227

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Add .h.in to C #7227

merged 3 commits into from
Feb 2, 2025

Conversation

donno2048
Copy link
Contributor

@donno2048 donno2048 commented Jan 31, 2025

From line 4256 (iirc) we know linguist does recognize dynamically created files

Checklist:

from line 4256 (iirc) we know linguist does recognize dynamically created files
@donno2048 donno2048 requested a review from a team as a code owner January 31, 2025 14:11
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the directions for adding a new extension as detailed in the CONTRIBUTING.md file and please put back and complete the "I am adding a new extension to a language." section of the PR template you have removed - it's there for a reason.

@donno2048
Copy link
Contributor Author

@lildude did you mean adding a sample? If so, I added one and updated the PR comment

add CEN64's common.h.in
@lildude
Copy link
Member

lildude commented Feb 1, 2025

If these files are dynamically created, would it make sense to mark them as generated as part of this PR? This means they will be suppressed in PR diffs and excluded from the stats by default.

@donno2048
Copy link
Contributor Author

@lildude they're used to generate .h files, kind of a header templating format, so it wouldn't make sense to mark them as generated, they're more "generating" files...

@lildude lildude changed the title Support dynamically created header file Add .h.in to C Feb 2, 2025
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Feb 2, 2025
Merged via the queue into github-linguist:main with commit 1647b5b Feb 2, 2025
5 checks passed
@donno2048 donno2048 deleted the patch-1 branch February 2, 2025 11:38
@Prasit05l

This comment has been minimized.

3 similar comments
@Prasit05l

This comment has been minimized.

@Prasit05l

This comment has been minimized.

@Prasit05l

This comment has been minimized.

@asif8419

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants