-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .h.in
to C
#7227
Add .h.in
to C
#7227
Conversation
from line 4256 (iirc) we know linguist does recognize dynamically created files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the directions for adding a new extension as detailed in the CONTRIBUTING.md file and please put back and complete the "I am adding a new extension to a language." section of the PR template you have removed - it's there for a reason.
@lildude did you mean adding a sample? If so, I added one and updated the PR comment |
add CEN64's common.h.in
If these files are dynamically created, would it make sense to mark them as generated as part of this PR? This means they will be suppressed in PR diffs and excluded from the stats by default. |
@lildude they're used to generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Important
The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.
From line 4256 (iirc) we know linguist does recognize dynamically created files
Checklist: