Skip to content

Conversation

@GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Jul 17, 2023

noop prefix enhancements

⚠️ This PR will introduce breaking changes to the way noop commands work ⚠️

This pull request officially splits out the "noop" command from the "deploy" command. There are a variety of reasons for why this must be done and these reasons can be seen in the block below and the linked issue.

Here is a TL;DR of why these changes are being made:

  • Allow for .deploy and .noop to be fully independent and customizable
  • "noop" commands are no longer a suffix of "deploy" commands
  • Helps to prevent accidental deployments since .deploy noop is rather similar to just a plain .deploy. Now .noop is more unique

The following text in this section is from #108 (comment)

I think the best solution here would be to have noop_trigger as a completely different keyword, rather than a subset of the trigger keyword.

For example:

current code does this

trigger: .deploy
noop_trigger: .noop

current code interprets this as

.deploy
.deploy .noop

That ^ is just silly. We want something like this:

future

trigger: .deploy
noop_trigger: .noop

current code interprets this as

.deploy
.noop

That was the noop command is no longer a suffix of .deploy and it is it's own standalone command.


resolves: #108

@GrantBirki GrantBirki added the enhancement New feature or request label Jul 17, 2023
@GrantBirki GrantBirki self-assigned this Jul 18, 2023
cwage
cwage previously approved these changes Jul 18, 2023
@jasonmacgowan
Copy link

What happens when I run .deploy noop after we roll this out?

@GrantBirki
Copy link
Member Author

What happens when I run .deploy noop after we roll this out?

The Action will respond with a message informing you that this command has been dropped and replaced with .noop. It will also provide a link to the new docs/deprecated.md document that explains why this change was made, how it may effect you, and what you can do for further customization.

@GrantBirki GrantBirki merged commit e598272 into main Jul 18, 2023
@GrantBirki GrantBirki deleted the noop-prefix-enhancement branch July 18, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .noop alias prefix for .deploy noop

4 participants