- 
                Notifications
    You must be signed in to change notification settings 
- Fork 61
noop prefix enhancements #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| What happens when I run  | 
| 
 The Action will respond with a message informing you that this command has been dropped and replaced with  | 
noop prefix enhancements
This pull request officially splits out the "noop" command from the "deploy" command. There are a variety of reasons for why this must be done and these reasons can be seen in the block below and the linked issue.
Here is a TL;DR of why these changes are being made:
.deployand.noopto be fully independent and customizable.deploy noopis rather similar to just a plain.deploy. Now.noopis more uniqueThe following text in this section is from #108 (comment)
I think the best solution here would be to have
noop_triggeras a completely different keyword, rather than a subset of thetriggerkeyword.For example:
That ^ is just silly. We want something like this:
That was the noop command is no longer a suffix of
.deployand it is it's own standalone command.resolves: #108