Java: Improve concatenation in loops #16859
Conversation
- create test - check for statements being executed often
- add test for recursive function - update test expectations
- Use a deep callgraph traversal to identify loops. This should be checked for performance issues and possibly be restriceted/optimised. - Add inline expectation test. Currently dupicating the query code. It should be refactored so that the code can be reused.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * An assignment of the form | ||
| * | ||
| * ``` | ||
| * v = ... + ... v ... | ||
| * ``` | ||
| * or | ||
| * | ||
| * ``` | ||
| * v += ... | ||
| * ``` | ||
| * where `v` is a simple variable (and not, for example, | ||
| * an array element). | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
| exists(ControlFlowNode n | a.getControlFlowNode() = n | getADeepSuccessor(n) = n) | ||
| } | ||
|
|
||
| /** Gets a sucessor of `n`, also following function calls. */ |
Check warning
Code scanning / CodeQL
Misspelling Warning
| exists(ControlFlowNode n | a.getControlFlowNode() = n | getADeepSuccessor(n) = n) | ||
| } | ||
|
|
||
| /** Gets a sucessor of `n`, also following function calls. */ |
Check warning
Code scanning / CodeQL
Misspelling Warning
| } | ||
|
|
||
| predicate queryResult(Assignment a) { | ||
| exists(Variable v | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
| /** | ||
| * Holds if `e` is executed often in loop `loop`. | ||
| */ | ||
| predicate executedOften(Assignment a) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
| /** | ||
| * Holds if `e` is executed often in loop `loop`. | ||
| */ | ||
| predicate executedOften(Assignment a) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
|
|
||
| module TheQuery { | ||
| import semmle.code.java.Type | ||
| import semmle.code.java.Expr |
Check warning
Code scanning / CodeQL
Redundant import Warning
| import semmle.code.java.Type | ||
| import semmle.code.java.Expr | ||
| import semmle.code.java.Statement | ||
| import semmle.code.java.JDK |
Check warning
Code scanning / CodeQL
Redundant import Warning
This is the results so far of a series of mob pairing sessions to improve the query finding concatenation in loops.
One thing I wanted to illustrate is the inline tests, but currently I had to include the query code in the test to make it work. Thus, this PR is not quite ready to merge.