Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Adopt shared SSA library #16900

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Java: Adopt shared SSA library #16900

merged 6 commits into from
Feb 11, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jul 3, 2024

No description provided.

@github-actions github-actions bot added the Java label Jul 3, 2024
@hvitved hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 1d5e5ac to 551238a Compare July 5, 2024 13:36
@hvitved hvitved force-pushed the java/shared-ssa branch from 551238a to 291e278 Compare July 8, 2024 09:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2024
View reviewed changes
java/ql/src/Violations of Best Practice/Dead Code/DeadLocals.qll
not exists(SsaImplicitInit init | init.captures(ssa)) and
not emptyDecl(ssa) and
not readImplicitly(ssa, _)
/** A dead variable update. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate without a result should start with 'Holds'.
@hvitved hvitved force-pushed the java/shared-ssa branch from 291e278 to 4f5d6e3 Compare July 8, 2024 11:43
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 4479e03 to a93188c Compare July 8, 2024 18:55
@hvitved hvitved force-pushed the java/shared-ssa branch from 132d68c to 5cdb692 Compare July 9, 2024 10:59
@hvitved hvitved mentioned this pull request Jul 9, 2024
Merged
@hvitved hvitved changed the title Java: Adopt shared SSA data-flow integration (WIP) Java: Adopt shared SSA library Jul 9, 2024
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from ab9d191 to 910f049 Compare July 10, 2024 07:45
@hvitved hvitved force-pushed the java/shared-ssa branch 3 times, most recently from 4db2c2b to 3d63764 Compare July 11, 2024 09:38
@hvitved hvitved force-pushed the java/shared-ssa branch 2 times, most recently from 308fce2 to de69820 Compare July 11, 2024 19:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2024
View reviewed changes
shared/ssa/codeql/ssa/Ssa.qll Outdated

private newtype TNode =
TParamNode(DfInput::Parameter p) {
exists(WriteDefinition def | DfInput::ssaDefInitializesParam(def, p))

Check warning

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.
@MathiasVP MathiasVP mentioned this pull request Sep 12, 2024
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2024
View reviewed changes
java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll
Location getLocation() { result = super.getLocation() }

predicate hasCfgNode(BasicBlock bb, int i) {
super.getControlFlowNode() = bb.(J::BasicBlock).getNode(i)

Check warning

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
BasicBlock
Loading
.
hvitved added a commit to hvitved/codeql that referenced this pull request Feb 10, 2025
@hvitved
Merge pull request #7 from aschackmull/java/shared-ssa-fixes
f8c0c6f 
Some fixes to github#16900
aschackmull
aschackmull previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did extensive black-box testing comparing this to the prior implementation. Discrepancies of course occurred for dead variables, but there were also a tiny few other discrepancies: some use-use differences related to unreachable code, which makes sense, and a few getPriorDef differences that were too minor to investigate further.

@aschackmull
Copy link
Contributor

Added two join-order fixes as inline suggestions.

aschackmull
aschackmull previously approved these changes Feb 10, 2025
View reviewed changes
@hvitved hvitved marked this pull request as ready for review February 10, 2025 20:49
@hvitved hvitved requested a review from a team as a code owner February 10, 2025 20:49
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 10, 2025
@aschackmull
Copy link
Contributor

We need a small tweak, as we currently have a semantic merge conflict with #18729.

@hvitved hvitved requested a review from aschackmull February 11, 2025 09:35
@hvitved hvitved merged commit a061b1e into github:main Feb 11, 2025
15 checks passed
@hvitved hvitved deleted the java/shared-ssa branch February 11, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aschackmull