Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: add UseTree::is_star #18611

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Rust: add UseTree::is_star #18611

merged 1 commit into from
Jan 29, 2025

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jan 28, 2025

Add predicate isStar() for statements like use std::fmt::*

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jan 28, 2025
hvitved
hvitved reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot; don't know if is_glob would be a more suitable name? Also, would be nice to have an extractor test for this.

@aibaars aibaars force-pushed the aibaars/use-tree-star branch from 06cdaa4 to 8d96c87 Compare January 28, 2025 15:12
@aibaars aibaars marked this pull request as ready for review January 29, 2025 13:41
@aibaars aibaars merged commit 54efb0a into main Jan 29, 2025
12 checks passed
@aibaars aibaars deleted the aibaars/use-tree-star branch January 29, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @hvitved