Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cargo dependencies #18789

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Upgrade cargo dependencies #18789

wants to merge 10 commits into from
+1,893 −1,308

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Feb 14, 2025 •
edited
Loading

  • rust-analyzer also requires a newer rustc.
  • Other tree-sitter extractors also need to run at least version 1.78, as that is the first version understanding the version 4 cargo lock format, which is the default since 1.83.
  • That also triggered new clippy and formatting warnings in the shared extractor code.

@Copilot Copilot bot review requested due to automatic review settings February 14, 2025 14:33
@redsun82 redsun82 requested a review from a team as a code owner February 14, 2025 14:33
Copilot
Copilot AI reviewed Feb 14, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 97 out of 97 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Feb 14, 2025
@redsun82 redsun82 added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Feb 14, 2025
@redsun82 redsun82 requested review from a team as code owners February 14, 2025 15:34
@redsun82 redsun82 marked this pull request as draft February 14, 2025 15:39
@redsun82 redsun82 marked this pull request as ready for review February 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
depends on internal PR This PR should only be merged in sync with an internal Semmle PR Python Ruby Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@redsun82