Skip to content

Convert remaining {go,swift,ruby}-code-scanning.qls query tests to .qlref #19817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Convert remaining {go,swift,ruby}-code-scanning.qls query tests to .qlref #19817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c62e78e
Go: convert UncontrolledAllocationSize test to .qlref
d10c Jun 19, 2025
8e292d1
Go: convert IncorrectIntegerConversion test to .qlref
d10c Jun 19, 2025
e153c78
Ruby: add PrettyPrintModels test postprocessor
d10c Jun 19, 2025
112ed64
Ruby: convert CommandInjection test to .qlref
d10c Jun 19, 2025
f1a290e
Ruby: convert InsecureDownload test to .qlref
d10c Jun 19, 2025
75702ca
Swift: convert PredicateInjection test to .qlref
d10c Jun 20, 2025
8e438c8
Swift: convert CleartextLogging test to .qlref
d10c Jun 20, 2025
3335393
Swift: convert PathInjection test to .qlref
d10c Jun 20, 2025
657e782
Swift: convert XXE test to .qlref
d10c Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions go/ql/test/query-tests/Security/CWE-681/FilterTestResults.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* @kind test-postprocess
* @description Remove the query predicates that differ based on 32/64-bit architecture. This should leave behind `invalidModelRowAdd` and `testFailures` in case of test failures.
*/

/**
* The input test results: query predicate `relation` contains `data` at (`row`, `column`).
*/
external private predicate queryResults(string relation, int row, int column, string data);

/** Holds if the test output's query predicate `relation` contains `data` at (`row`, `column`). */
query predicate results(string relation, int row, int column, string data) {
queryResults(relation, row, column, data) and
not relation in ["#select", "nodes", "edges"]
}
2 changes: 0 additions & 2 deletions go/ql/test/query-tests/Security/CWE-681/IncorrectIntegerConversion.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +0,0 @@
invalidModelRow
testFailures
Loading
Loading