Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-commands-for-github-actions.md #21599

Closed
wants to merge 1 commit into from

Conversation

ujjwal-shekhar
Copy link
Contributor

@ujjwal-shekhar ujjwal-shekhar commented Oct 25, 2022

Why:

Closes #21529

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added a Note at the end of the Multiline Strings section that clarifies it's use cases.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 25, 2022
@cmwilson21
Copy link
Contributor

@ujjwal-shekhar Thanks so much for opening a PR! I edited your post slightly to link it to the issue. 🔗

I'll get this triaged for review ⚡

@ujjwal-shekhar
Copy link
Contributor Author

@ujjwal-shekhar Thanks so much for opening a PR! I edited your post slightly to link it to the issue. 🔗

I'll get this triaged for review ⚡

@ujjwal-shekhar
Copy link
Contributor Author

The repo seems to be frozen, could you look in it. :)

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 26, 2022
@cmwilson21
Copy link
Contributor

@ujjwal-shekhar We had a freeze while we merged some larger files. It's thawed now. Your PR is waiting for review. A writer will take a look at it soon 👀

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Oct 26, 2022
@cmwilson21
Copy link
Contributor

👋 @ujjwal-shekhar - After checking into this a bit further, could you update the PR to reflect the comment here? Meaning, add a link to the setting an output parameter section, pointing people to the multi-line strings section section.

Check out our style guide's section on links for additional information.

We really appreciate your interest in improving the docs! 💖

@cmwilson21 cmwilson21 added the more-information-needed More information is needed to complete review label Oct 26, 2022
@cmwilson21
Copy link
Contributor

@ujjwal-shekhar 👋 Checking in again, are you able to make the requested changes in the comment above? 💖

@lecoursen
Copy link
Member

I'm going to close this PR for now. If you decide to update it as described by @cmwilson21 in #21599 (comment), feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how multiline output values can be set via GITHUB_OUTPUT
3 participants