Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor isPixelActive into calculatePixelIntensity #27

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chrisreddington
Copy link
Collaborator

This pull request aims to address #13. It includes changes to improve the rendering of text and images by using pixel intensity instead of a binary pixel check.

In addition to the implementation change, there are tweaks to the tests, with the introduction of a new gradient circle test to check that the intensity calculations are working as expected, and not providing a binary 0 or 1.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Update text rendering to use grayscale values for embossing height.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@chrisreddington chrisreddington linked an issue Dec 9, 2024 that may be closed by this pull request
5 tasks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Feature]: Enhance text embossing with grayscale height mapping
1 participant