fix(GHES): Remove versioning from GraphQL API endpoint URL in discussions.py #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This pull request modifies the GraphQL API endpoint URL construction in the
discussions.py
file. The change ensures proper handling of GitHub Enterprise Server (GHES) GraphQL API endpoints./v3
from the API endpoint construction as GraphQL APIs in GHES use/api/graphql
instead of/api/v3/graphql
According to the GitHub Enterprise Server GraphQL documentation, the correct endpoint format is
http(s)://HOSTNAME/api/graphql
. Unlike REST APIs which use versioning (/api/v3
), GraphQL APIs in GHES do not include version numbers in the URL path.Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
, orbreaking