This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
add projection test handlers to test suite #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this option instead of the blanket --retval option will allow handler test programs to inject error (or other) responses only at times determined by the test script.
When the file specified with --retval-file exists, the test handlers log messages on each event; when the file does not exist, no messages are output from the test handlers. This commit has no functional change on the test suite, but once we add test handlers for projection events, we will need to toggle test handler output on and off, or else initial projection events triggered by external system processes may interfere with our tests. (If additional control proves necessary in the future, we can also add a list of valid process names or process groups to the control file and then only report handler events corresponding to those processes.)
chrisd8088
force-pushed
the
projection-test-handlers
branch
from
0775f50 to
76946dd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address most of #7 as it is written, although more work is required to actually test direction projection, so that'll be a follow-up PR or two.
The primary changes here add the
--retval-fileoption so that the simple new projection-callback logging added in 0775f50 only generates messages when they are expected by the test scripts. Otherwise, background processes (likegvfs-udisks2-volume-monitoror even ourwait_mounthelper) cause initial log messages as they probe the new mount point which then throw off our tests. We only want to start logging once things are up and running, after we know that -- at a minimum --wait_mount(if not some other system daemon) has ensured that at least one program has triggered projection (really, hydration) of the top-level mount point directory.We can also control the return values injected by the test handlers by placing values into the "control file" specified with
--retval-file. This isn't used much yet, but we could potentially combine many of the existing test scripts using this functionality.