Mona Sans on GF #82
Open
Mona Sans on GF #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge that PR yet, we are still in discussion to know what approach to use for the name table. I'll let you know |
|
Hi @tobiasahlin! I see you added some commits 3 days ago. Do you think it's possible for you to include my changes? |
|
Hi @tobiasahlin! If you could merge that PR, it would be great! :) We are planning to onboard these fonts very soon! |
|
Waiting on the review / merge of this PR to continue onboarding in Google Fonts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Here you can find the fonts build + the name table updated manually. For now, I let the .ttx in the fonts folder, just in case we have some other modifications to do before it reaches the API. Feel free to remove it once the font is live!
I fixed some small issues, you can have a look to the commits to see the details.
I had to merge the eogonek to avoid a bad result in the exports:
Otherwise, all looks good!
Cheers!