Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Duplicate Approvals #125

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Prevent Duplicate Approvals #125

merged 4 commits into from
Nov 28, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Nov 28, 2023

Prevent Duplicate Approvals

Currently, if this workflow is run multiple times or re-triggered for any reason, it will continuously add approvals to a pull request. This is messy and creates un-wanted noise on a pull request. This PR makes adjustments to the code so that if a PR is already approved by this Action, it will log that as the result and exit; without making duplicate approvals.

@GrantBirki GrantBirki added bug Something isn't working enhancement New feature or request labels Nov 28, 2023
Copy link
Member

@northrup northrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice

@GrantBirki GrantBirki merged commit 245059b into main Nov 28, 2023
@GrantBirki GrantBirki deleted the prevent-duplicate-approvals branch November 28, 2023 20:02
kodiakhq bot referenced this pull request in weareinreach/TransMascFutures Nov 29, 2023
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github/privileged-requester](https://togithub.com/github/privileged-requester) | action | minor | `v2.0.0` -> `v2.1.0` |

---

### Release Notes

<details>
<summary>github/privileged-requester (github/privileged-requester)</summary>

### [`v2.1.0`](https://togithub.com/github/privileged-requester/releases/tag/v2.1.0)

[Compare Source](https://togithub.com/github/privileged-requester/compare/v2.0.0...v2.1.0)

#### What's Changed

-   Bump actions/upload-artifact from 3.1.0 to 3.1.3 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/github/privileged-requester/pull/99](https://togithub.com/github/privileged-requester/pull/99)
-   Prevent Duplicate Approvals by [@&#8203;GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/125](https://togithub.com/github/privileged-requester/pull/125)
-   properly fetch "login" when using Actions tokens instead of a PAT by [@&#8203;GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/126](https://togithub.com/github/privileged-requester/pull/126)
-   fix 'github-actions\[bot]' usage by [@&#8203;GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/127](https://togithub.com/github/privileged-requester/pull/127)
-   fix hasAlreadyApproved() method by [@&#8203;GrantBirki](https://togithub.com/GrantBirki) in [https://github.com/github/privileged-requester/pull/128](https://togithub.com/github/privileged-requester/pull/128)

**Full Changelog**: github/privileged-requester@v2.0.0...v2.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD).



PR-URL: #265
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants