more WIP fixes

github · May 30, 2024 · 780abdf · 780abdf
1 parent d325dce
commit 780abdf
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/go/pools/smartconnpool/pool.go b/go/pools/smartconnpool/pool.go
@@ -337,7 +337,10 @@ func (pool *ConnPool[C]) put(conn *Pooled[C]) {
 
 	if conn == nil {
 		var err error
-		conn, err = pool.connNew(context.Background())
+		// TODO: Do we really want to wait for up to a second here?
+		ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+		defer cancel()
+		conn, err = pool.connNew(ctx)
 		if err != nil {
 			pool.closedConn()
 			return

diff --git a/go/vt/vttablet/tabletserver/repltracker/poller.go b/go/vt/vttablet/tabletserver/repltracker/poller.go
@@ -17,6 +17,7 @@ limitations under the License.
 package repltracker
 
 import (
+	"context"
 	"sync"
 	"time"
 
@@ -45,7 +46,10 @@ func (p *poller) Status() (time.Duration, error) {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 
-	status, err := p.mysqld.ReplicationStatus()
+	ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+	defer cancel()
+
+	status, err := p.mysqld.ReplicationStatusWithContext(ctx)
 	if err != nil {
 		return 0, err
 	}

diff --git a/go/vt/vttablet/tabletserver/repltracker/reader.go b/go/vt/vttablet/tabletserver/repltracker/reader.go
@@ -142,14 +142,15 @@ func (r *heartbeatReader) Status() (time.Duration, error) {
 func (r *heartbeatReader) readHeartbeat() {
 	defer r.env.LogError()
 
-	ctx, cancel := context.WithDeadline(context.Background(), r.now().Add(r.interval))
+	ctx, cancel := context.WithTimeout(context.Background(), r.interval)
 	defer cancel()
 
 	res, err := r.fetchMostRecentHeartbeat(ctx)
 	if err != nil {
 		r.recordError(vterrors.Wrap(err, "failed to read most recent heartbeat"))
 		return
 	}
+
 	ts, err := parseHeartbeatResult(res)
 	if err != nil {
 		r.recordError(vterrors.Wrap(err, "failed to parse heartbeat result"))