Skip to content

Commit

Permalink
[release-16.0] 16.0.8 release notes: ExecuteFetchAsDBA breaking change (
Browse files Browse the repository at this point in the history
vitessio#15012)

Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]>
  • Loading branch information
shlomi-noach and deepthi authored Jan 24, 2024
1 parent 39cc3c1 commit a70c3be
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
25 changes: 25 additions & 0 deletions changelog/16.0/16.0.8/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
## Summary

### Table of Contents

- **[Major Changes](#major-changes)**
- **[Breaking Changes](#breaking-changes)**
- [ExecuteFetchAsDBA rejects multi-statement SQL](#execute-fetch-as-dba-reject-multi)

## <a id="major-changes"/>Major Changes

### <a id="breaking-changes"/>Breaking Changes

#### <a id="execute-fetch-as-dba-reject-multi"/>ExecuteFetchAsDBA rejects multi-statement SQL

`vtctldclient ExecuteFetchAsDBA` (and similarly the `vtctl` and `vtctlclient` commands) now reject multi-statement SQL with error.

For example, `vtctldclient ExecuteFetchAsDBA my-tablet "stop replica; change replication source to auto_position=1; start replica` will return an error, without attempting to execute any of these queries.

Previously, `ExecuteFetchAsDBA` silently accepted multi statement SQL. It would (attempt to) execute all of them, but:

- It would only indicate error for the first statement. Errors on 2nd, 3rd, ... statements were silently ignored.
- It would not consume the result sets of the 2nd, 3rd, ... statements. It would then return the used connection to the pool in a dirty state. Any further query that happens to take that connection out of the pool could get unexpected results.
- As another side effect, multi-statement schema changes would cause schema to be reloaded with only the first change, leaving the cached schema inconsistent with the underlying database.

`ExecuteFetchAsDBA` does allow a specific use case of multi-statement SQL, which is where all statements are in the form of `CREATE TABLE` or `CREATE VIEW`. This is to support a common pattern of schema initialization.
2 changes: 2 additions & 0 deletions changelog/16.0/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## v16.0
The dedicated team for this release can be found [here](team.md).
* **[16.0.8](16.0.8)**

* **[16.0.7](16.0.7)**
* [Changelog](16.0.7/changelog.md)
* [Release Notes](16.0.7/release_notes.md)
Expand Down

0 comments on commit a70c3be

Please sign in to comment.