Fix problem with detecting storage folder on windows

[elenatanasoiu]

Discovered by @shati-patel here.

The getFirstStoragePath() method would break on windows:

Path contains invalid characters: /c:/git-repo/codespaces-codeql (codeQL.createSkeletonQuery)

This makes sense, since we're looking to get the parent folder by splitting for /. In Windows, paths use \ instead of /. So let's detect the platform and add a test for this case.

[shati-patel]

Elena & I paired on testing this on Windows—just double-checking that the fix works in the starter workspace too, and then I'll push up the changes! 🙌🏽

[elenatanasoiu]

Thanks for fixing this up Shati ❤️ I've just tested this and it downloads the database successfully on Mac as well + creates the QL pack!

There's one more thing we need to solve here now that we've made it work on Mac + Windows: we're downloading the database as a workspace folder (see screenshot) when it should actually be using the workspaceStorage folder (e.g. /Users/<>/Library/Application Support/Code/User/workspaceStorage/0bbefad4b919c9a4116bab45b1eef1ec/GitHub.vscode-codeql). This is the folder we pass in when we call downloadGitHubDatabase and it's taken off ctx.storagePath.fsPath.

I think what we want to do is use two separate paths:

1. for creating folders we use getFirstStoragePath()
2. for creating databases we'll need to pass ctx.storageUri.fsPath down from the extension (like I was doing here before I reversed it).

Not sure how much more time you want to spend on this. I'm happy to add an extra commit to separate the two paths but if you want to take the reins, let me know.

[elenatanasoiu]

I've added two extra commits to split out:

• the path we use for creating QL pack folders (qlPackFolderPath)
• the path we use for downloading databases (databaseStoragePath)

I've tested this on Mac for codespaces-codeql & the starter workspace.

[koesie10]

Can we use App here to avoid introducing new dependencies on the ExtensionContext? That should also contain a workspaceStoragePath and globalStoragePath as strings which shortens the code below as well.

[elenatanasoiu]

Very cool! Have pushed a change to use App.