Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'compare performance' view #3843
Add 'compare performance' view #3843
Changes from 37 commits
3b06977
96aa770
aaf23ea
70ec570
8268d68
58afeba
03ca407
317e52c
876c5b6
260bf0e
453aa83
ccf2dc6
412338c
6d4427e
e039f6b
1d2c2cf
b05ec33
20f6e3d
558d957
6568b56
6f7eb74
62f3b4f
9800fa1
d008963
eec42c5
9a0699f
48954c7
ab00152
4a835b8
568f082
2cae71c
d37469f
8a58279
b9d1551
afa3d55
c99bf5b
aa528c6
6f461e7
2293cc3
08bffab
44d33d6
f09210b
37dcd08
370b17c
8b8d174
bba31c0
666c26e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to remove references to
resultsView
andlabelProvider
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...not sure what the lifecycle of the view is. Is there a single
view
instance created for the entire extension, or is it one view per window that's opened?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instance of this class persists across multiple open/close of the panel so I'd say we shouldn't dispose of these fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see how
onPanelDispose
is called in the super class. Your implementation here is fine.