Report error messages for all unmatched templates. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s worth noting that this would work with ats2 as well |
|
It is good that you took the initiative. I will find some time to read the source. |
… catch_unmatched_templates
|
I like the idea. Finding ATS templates that need to be implemented based on the generated C code is time-consuming. |
|
This is definitely a must-have feature!
I will get back to it after the first ATS-Temptory release is pushed out.
…On Mon, May 27, 2019 at 11:00 AM Artyom Shalkhakov ***@***.***> wrote:
I like the idea. Finding ATS templates that need to be implemented based
on the generated C code is time-consuming.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAEXZV7ESMOILYWOYWEEYD3PXPZR5A5CNFSM4HMUZZX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKALHY#issuecomment-496240031>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEXZVY3XTWIGSCZR527KALPXPZR5ANCNFSM4HMUZZXQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a possibility...
If there are reasons against doing so? Or perhaps, something I have overlooked i.e. targeting c++ templates, etc.
At the very least, we can output some warning message at this location, here
The nice thing about throwing an exception is that we will not waste time emitting code when we know that the emitted code will throw error(s) from gcc or the like.
The only thing remaining is to remove the file that was opened earlier in ccomp phase in the event that this exception gets thrown.