Skip to content

Commit

Permalink
Make sessionScopes a trusted value
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanp413 committed Sep 12, 2023
1 parent f613d83 commit 3cdda93
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/authentication/authentication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export default class GitpodAuthenticationProvider extends Disposable implements
if (sortedScopes.length !== sortedFilteredScopes.length) {
this.logService.warn(`Creating session with only valid scopes ${sortedFilteredScopes.join(',')}, original scopes were ${sortedScopes.join(',')}`);
}
flow.scopes = JSON.stringify(sortedFilteredScopes);
flow.sessionScopes = JSON.stringify(sortedFilteredScopes);
this.telemetryService.sendUserFlowStatus('login', flow);

const scopeString = sortedFilteredScopes.join(' ');
Expand Down
3 changes: 2 additions & 1 deletion src/common/telemetry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { cloneAndChange, escapeRegExpCharacters, isBuiltFromGHA, mixin } from '.
import fetch from 'node-fetch-commonjs';

export const TRUSTED_VALUES = new Set([
'gitpodHost'
'gitpodHost',
'sessionScopes'
]);

export interface TelemetryEventProperties {
Expand Down

0 comments on commit 3cdda93

Please sign in to comment.