[server] try to fix org membership on login #18399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case it didn't succeed on first attempt this might help during the following ones.
svenefftinge
reviewed
Aug 1, 2023
|
/unhold |
AlexTugarev
commented
Aug 1, 2023
| orgId: string, | ||
| memberId: string, | ||
| role: OrgMemberRole, | ||
| ): Promise<void> { | ||
| await this.auth.checkPermissionOnOrganization(userId, "write_members", orgId); | ||
| if (userId) { |
There was a problem hiding this comment.
@svenefftinge, now thinking about that change. This could actually be the fix.
There was a problem hiding this comment.
Just curious, why this is not happening on dogfood?
There was a problem hiding this comment.
The featureflag is disabled. So these checks don't throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case it didn't succeed on first attempt this might help during the following ones.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 69f54c6
Refactor
iam-session-app.tsto optimize login with OIDC and organization membership. Reduce database queries and check organization validity.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold