update node to 18.17.1 #18525
Merged
update node to 18.17.1 #18525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/hold
do-not-merge/work-in-progress
size/S
size/M
and removed
size/S
labels
AlexTugarev
force-pushed
the
at/node-18-17-1
branch
from
234847a
to
8d69efa
Compare
AlexTugarev
force-pushed
the
at/node-18-17-1
branch
from
8d4b4b9
to
65d1945
Compare
jeanp413
reviewed
Aug 19, 2023
jeanp413
force-pushed
the
at/node-18-17-1
branch
from
65d1945
to
d95deaf
Compare
aledbf
approved these changes
Aug 23, 2023
|
@jeanp413 it seems that checkboxes have stopped working 🤔 |
|
@filiptronicek fixed |
filiptronicek
approved these changes
Aug 23, 2023
| @@ -4,6 +4,10 @@ | |||
| * See License.AGPL.txt in the project root for license information. | |||
| */ | |||
|
|
|||
| @tailwind base; | |||
There was a problem hiding this comment.
I assume we need to have this at the beginning of any css file where we're using a tailwind directive now?
There was a problem hiding this comment.
supposedly it shouldn't be needed with the postcss-import plugin in the postcss.config.js but I spend a lot of time yesterday trying to make it work but couldn't 😞
because it was just three files for now I just copy the directive, but it would be good to fix it later
|
|
akosyakov
approved these changes
Aug 24, 2023
|
/unhold |
This was referenced Sep 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at f2eb927
Updated the node version from 16.x to 18.17.1 in the Dockerfiles for several gitpod components and the dev image. Added an environment variable to enable the openssl-legacy-provider option for node 18 compatibility.
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold